Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create zsh.go #44

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Create zsh.go #44

wants to merge 1 commit into from

Conversation

DrxcoDev
Copy link

Description

☕Implemented functions to manage the installation, uninstallation, and updating of Zsh on both Linux and macOS platforms. The script detects the operating system and dynamically selects the appropriate package manager (apt, yum, pacman for Linux; Homebrew for macOS). The InstallZsh function installs Zsh by determining the correct command based on the available package manager, while UninstallZsh removes it in a similar manner. Additionally, an UpdateZsh function was added to handle the package update process. This commit ensures cross-platform compatibility and robust package management logic, enhancing automation for users across different environments.

Related Issues (if any)

None

Type of Changes

Please mark the options that best describe your PR:

  • Bug fix
  • New feature
  • Enhancement
  • Refactor
  • Documentation update
  • CI/CD changes
  • Dependencies update
  • Other (please specify):

Checklist

  • I have read and followed the CONTRIBUTING.md guidelines for this project.
  • Added unit tests that cover the new/modified code.
  • All existing tests pass (go test ./...).
  • Added or updated documentation if needed (e.g., README.md, code comments).
  • Public functions and structs are well-documented using GoDoc conventions.
  • If the PR introduces a new feature, it has been documented clearly for users.
  • Ensure proper error handling and meaningful error messages.
  • Ensure any logging follows best practices (e.g., no excessive or sensitive logging).
  • Dependencies added are necessary and minimal.

Additional Notes

None

Add functions to install, uninstall, and update Zsh for Linux and macOS with package manager detection.
@DiegoDev2
Copy link
Owner

DiegoDev2 commented Oct 28, 2024

Thank you for your contribution and effort on this pull request. I appreciate your work! However, I’d like to avoid relying on external package managers directly, as Fleet’s formula approach is designed to handle installations internally through specific methods in each formula.

Could you please update the code to follow the installation methods already used in the formulas, without invoking external package managers directly? This would keep Fleet’s structure consistent and reduce external dependencies.

Let me know if you have any questions or need further clarification. Thanks again! @DrxcoDev

@DiegoDev2 DiegoDev2 assigned DiegoDev2 and DrxcoDev and unassigned DiegoDev2 Oct 28, 2024
@DiegoDev2 DiegoDev2 requested review from DiegoDev2 and removed request for DiegoDev2 October 28, 2024 20:44
Copy link
Owner

@DiegoDev2 DiegoDev2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like I said before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants